docs: follow libmuslim 2026.08.20, and correct two claims the release made false - #33
Merged
Conversation
… made false Download pins move from 2026.08.19 to 2026.08.20, and the tag-versus-header note now reads prayertimes.h v0.2.1. Two statements stopped being true and were verified against the libraries rather than edited by inspection. The Dart quick-start said the Tromso midsummer call returns a Fajr of 00:27 under the default MWL parameters. It returns 00:24. libmuslim#68 now solves the whole polar day at the reference latitude instead of borrowing only sunrise and sunset, so the value moved. Checked by running the documented call. Both the C and Dart API pages said MWL and Moonsighting resolve every field at every latitude. They no longer do. libmuslim#69 stopped reporting asr where the Sun casts no shadow, and there is a narrow band, four days a year at Longyearbyen, where the Sun is visible only by refraction: sunrise exists and fajr, maghrib and isha all resolve, but nothing casts a shadow, so asr alone is non-finite even under MWL. The other v0.2.0 mentions across the docs are historical statements about when sunrise and dhuha were removed, and remain correct. npm run build succeeds.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows
2026.08.20,prayertimes.hv0.2.1.Download pins
2026.08.19becomes2026.08.20, and the tag-versus-header note now readsv0.2.1alongsidehijri.handtimezone.hatv0.1.0.This matters more than a version bump usually would. The
2026.08.19asset reports prayers out of order at high latitude and returns a formula artifact as an asr time, and its header calls itselfv0.2.0exactly as the fixed one did before the bump. A reader following the old curl command could not tell the difference by reading the file.Two claims the release made false
Both were checked by running the libraries, not by reading the pages.
The Dart quick-start had the wrong time. It said the Tromso midsummer call returns a Fajr of
00:27under the default MWL parameters.It returns
00:24. libmuslim#68 now solves the whole polar day at the reference latitude rather than borrowing only sunrise and sunset, so the value moved by three minutes.Both the C and Dart pages claimed MWL and Moonsighting resolve every field at every latitude. They no longer do.
libmuslim#69 stopped reporting asr where the Sun casts no shadow. There is a narrow band, four days a year at Longyearbyen, where the separation from the declination sits between 90 and 90.833 degrees: the Sun is visible only by refraction, so sunrise exists and fajr, maghrib and isha all resolve, but nothing casts a shadow. On those days
asralone is non-finite, even under MWL.Carrying a reference latitude is not the same as always resolving, and both pages now say so.
Left alone deliberately
The remaining
v0.2.0mentions across the docs are historical statements about whensunriseanddhuhawere removed. Those are still accurate and changing them tov0.2.1would make them wrong.Verification