docs: follow the Dart binding to libmuslim 0.1.0 on pub.dev - #35
Closed
rizukirr wants to merge 3 commits into
Closed
docs: follow the Dart binding to libmuslim 0.1.0 on pub.dev#35rizukirr wants to merge 3 commits into
rizukirr wants to merge 3 commits into
Conversation
The package is published as libmuslim rather than libmuslim_dart, so the git dependency becomes dart pub add and every import and prose mention follows. The repository keeps the longer libmuslim-dart name, which the overview now says out loud so the two do not read as a typo. Three claims were false against the current library, each checked by running it rather than by reading the source. Jakarta isha on 2026-07-12 under Kemenag is 19:09, not 19:08. The other four times in the quick start still match. Tromso midwinter under Kemenag loses asr and maghrib, not maghrib alone. The sun does not rise, so there is no sunset to measure maghrib from and nothing casts a shadow. Both files said maghrib alone. HighLatMethod is no longer a lever wired to nothing. It is exposed as HighLatitudeRule, so the C comparison row that called it unexposed is replaced. HighLatitudeRule was missing from the docs entirely despite being exported. It gets its own section with all five members, the two new parameters on both CalculationParameters constructors, a quick start section, an errors row, and a parameter table on .of, which had none. The preset table gains the high latitude rule and reference latitude read from METHOD_TABLE, where only mwl and moonsighting carry a reference latitude. Documented as it stands rather than as it should be: CalculationParameters.custom validates neither at construction nor at the call, so an out of range highLatitudeReferenceLatitude reaches C unchecked, while .of does check it. Platform support replaces the Linux only paragraph with the five target table, keeping the caveat that Linux x64 is the only one actually tested, and a vendored header section records prayertimes.h v0.2.3 from release 2026.08.22.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
docs/libmuslim/dartto the current state of the Dart binding. Every factual change was checked by running the library against the vendoredprayertimes.hv0.2.3, not by reading the source.The package was renamed
Published on pub.dev as
libmuslim, notlibmuslim_dart. The git dependency becomesdart pub add libmuslim/flutter pub add libmuslim, and every import and prose mention follows. The repository keeps the longerlibmuslim-dartname, which the overview now states explicitly so the two do not read as a typo.Three claims were false
19:0819:09HighLatMethodHighLatitudeRuleThe Tromso correction appears in both
quick-start.mdandapi-reference.md. The sun does not rise, so there is no sunset to measure maghrib from and nothing casts a shadow. The other four Jakarta times still match.HighLatitudeRulewas undocumentedIt is exported but appeared nowhere in the docs. Added:
highLatitudeRuleandhighLatitudeReferenceLatitudeon bothCalculationParametersconstructors.of, which previously had noneMETHOD_TABLE, where onlymwl(45) andmoonsighting(60) carry a reference latitudeOne gap documented rather than hidden
CalculationParameters.customvalidateshighLatitudeReferenceLatitudeneither at construction nor at thePrayerTimescall, so an out of range value reaches C unchecked..ofdoes check it. This looks like an oversight in the binding rather than a deliberate asymmetry, so it is worth a follow up there. The docs describe the behaviour as it currently stands.Also
Platform support replaces the "Linux only" paragraph with the five target table, keeping the caveat that Linux x64 is the only target the test suite has actually been run on. A new vendored header section records
prayertimes.hv0.2.3from release 2026.08.22.