docs: follow libmuslim 2026.08.22, and fix the Dart package name - #36
Merged
Conversation
The site last followed 2026.08.20. Two releases have landed since, and one of them changed a status a caller has to switch on. Download pins move to 2026.08.22, and the tag-versus-header note now reads prayertimes.h v0.2.3, hijri.h v0.1.1 and timezone.h v0.1.1. HIJRI_EVENT_NOT_FOUND is no longer reserved. Since hijri.h v0.1.1 the moonset finder returns it for roughly one evening in thirty at every latitude, because it scans 24 hours and the Moon sets once per 24h 50m. The page said the status came only from the conjunction finders and from non-finite input, which would lead a caller to treat a normal result as impossible. The Hijri overview gains a supported range section. hijri.h now carries a measured contract rather than a description of whatever the tests covered, and none of it was on the site: validated 1900 to 2100, the Umm al-Qura table window, why the real limit is the margin rather than the date, and the latitude table where the verdict rate is flat to 60 and then collapses. The Dart package is named libmuslim on pub.dev, not libmuslim_dart, and it has been published since 2026-08-20. Every import line, the pubspec block and the "not yet published" sentence were wrong, so nothing on those pages built as written. The minimum SDK is 3.12.2 rather than 3.12. One Dart claim was wrong before this release too. Tromso on 21 December under Kemenag loses Asr as well as Maghrib, since the Sun does not rise, so there is no sunset and nothing casts a shadow. Verified by running the package: [Prayer.asr, Prayer.maghrib].
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows
2026.08.21and2026.08.22. The site last followed2026.08.20.Every claim below was checked by running the libraries, not by reading the pages.
The Dart pages did not build as written
This is the one that matters most, and it is not release drift. The package was renamed on 2026-08-20 and published to pub.dev the same day.
The install section also said "The package is not yet published on pub.dev. Depend on it by Git". A reader following either page got a package that does not exist. All 13 occurrences are fixed,
dart pub add libmuslimreplaces the Git dependency, and the two pages now say plainly that the pub.dev name and the repository name are different strings.The minimum SDK is
^3.12.2, so the pages now say 3.12.2 rather than 3.12.A status that callers switch on stopped being reserved
hijri.hv0.1.1fixed libmuslim#82. Both set finders used to classify a failed search from one extra sample, which works for the Sun and does not work for the Moon, whose day is 24h 50m.The C Hijri reference said
HIJRI_EVENT_NOT_FOUNDcomes from the conjunction finders and from non-finite input.hijri_find_moonsetnow returns it too, for roughly one evening in thirty at every latitude, Jakarta and Mecca included. A 24 hour window holding no moonset is not a circumpolar Moon. The page would have led a caller to treat a normal result as impossible, so it now carries a caution saying to add that arm before upgrading.Download pins
2026.08.20becomes2026.08.22, and the tag-versus-header note now readsprayertimes.hv0.2.3,hijri.hv0.1.1andtimezone.hv0.1.1, with the2026.08.21tag named as the one that still carriedhijri.hatv0.1.0.A supported range section for the Hijri pages
hijri.hgained a measured range statement in2026.08.21and2026.08.22, closing the second half of libmuslim#27. None of it was on the site. The overview now carries the dates, the geography, and the part that is easy to get wrong: the limit is availability, not accuracy.The 3.4 percent of evenings at the equator with no verdict is not a latitude effect at all, it is the Moon's period, and saying so is the difference between a reader trusting the number and a reader filing a bug.
One Dart claim that was wrong before this release too
The quick start said Tromso on 21 December under Kemenag "loses only Maghrib". Run against the package:
Asr is unavailable as well, because the Sun does not rise, so there is no sunset for Maghrib and nothing casts a shadow for Asr. The same call against the
2026.08.20asset gives the same answer, so this was a documentation error rather than something a release changed.Checked and deliberately left alone
The MWL Fajr of
00:24in the same section is correct and was not touched. The Dart API returns UTC instants, so 02:24 local at UTC+2 is what the C library returns and00:24is what the reader sees.The Longyearbyen "four days a year" claim holds exactly: 2026-02-16, 02-17, 10-25 and 10-26 are the days where Asr alone is non-finite under MWL.
The Rust pages needed nothing. The crate is
libmuslim-rs, the library islibmuslim, and the MSRV is 1.85, all still true.Remaining
v0.2.0andv0.2.1mentions elsewhere are historical statements about when something changed. They are still accurate and rewriting them would make them wrong.Verification
AI usage
Written with Claude Code. Every number on the changed pages was produced by compiling the current headers and running the Dart package, and the release-drift claims were diffed against the published
2026.08.20asset rather than trusted.