fix: Added missing key to templateShadowRoot#7
Merged
spuppo-mux merged 1 commit intomuxinc:mainfrom Nov 18, 2025
Merged
Conversation
spuppo-mux
added a commit
to muxinc/media-chrome
that referenced
this pull request
Nov 27, 2025
Relates to muxinc/next-video#397 and muxinc/ce-la-react#7 Upgrades ce-la-react to prevent missing key warning when using custom components on SSR.
luwes
pushed a commit
to muxinc/elements
that referenced
this pull request
Dec 1, 2025
Relates to muxinc/next-video#397 and muxinc/ce-la-react#7 Upgrades ce-la-react to prevent missing key warning when using custom components on SSR.
This was referenced Dec 3, 2025
spuppo-mux
added a commit
to muxinc/player.style
that referenced
this pull request
Dec 4, 2025
Relates to muxinc/next-video#397 and muxinc/ce-la-react#7 Upgrades ce-la-react to prevent missing key warning when using custom components on SSR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
The way we create the children array in the SSR case (
typeof window === 'undefined') would cause a warning log to appear on NextJS environments. For example: muxinc/next-video#397This was happening because
reactProps.childrenwas being created as an arraybut the
templateShadowRootelement didn't have a key. Tried to go for a unique enough key so it wouldn't be repeated, but feel free to suggest changes.Unrelated to the bug, I also modified the way we pass the children to the createElement function to follow how it's specified in the docs.
I tested this by publishing the package locally using yalc and linking it to
@mux/mux-video(and doing the same with this package andnext-videoand it's example). Then when running the example, you shouldn't see the missing key warning.