feat: news player#1115
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
luwes
marked this pull request as draft
May 7, 2025 17:30
* feat(playback-core): Allow for overriding default mux-embed (instance and options) for things like ads extensions. * feat(mux-video-ads): Add google-ima mux-embed extension and use it for mux-video-ads. * chore(mux-video-ads): Update vanilla example for ads playback for testing. Use ESM instead of CJS for mux-video-ads import. * build(mux-video-ads): Update to latest version of google ima data sdk extension.
* Create component for playlist post video * Changes in post video component * improve playlist structure * css styling improvement * Refactor * Add playlist component * Integrate playlist and post video screen * Handle click on end video screen * Commit package lock * fix resizing on video element * Use different ads * Use better videos * Re render after reproducing all videos * Fix issues when selecting related videos * Run timer until 0 * Add new props to mux player * support dynamic video element in template * Integrate ads to mux player and mux-player-react * Fix error * Fix progress bar during ad * some fixes * controls fixes * connecting fullscreen with muxplayer * add fullscreen behavior for mux player * add responsiveness and improve fullscreen * Use MuxPlayer in playlist component * Fix re rendering issue * Change repeated ad * fix on ad loader fails to retrieve an ad * fix resize on using html component alone * improve events to propagate parent * Expose adBreak to media theme * add custom theme * update theme * Expose adBreak to media theme * Refresh mediaadbreak prop in react component * Show message when user has ad blocker * Remove bottom black line from player * update theme with post videos * fix for post theme * add duration on the centered button on start * Remove MuxVideoAds dependency from MuxPlayer * Show error message when using ad blocker * Show error message when using ad blocker * playlist fullscreen issue fixed * fix spacer in theme * Remove unnecesary dependencies --------- Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
* starting fixing issue with ios native and mse * native playback is working * remove unnecesary comments --------- Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com>
* fix: mux-video-ads set up immediately * fix: mse / native check + add Mux data ads * feat: add mux-data-keep-session + fix iOS ads native playback
* Handle picture in picture * Implement suggested improvements
luwes
marked this pull request as ready for review
May 7, 2025 18:30
luwes
added a commit
that referenced
this pull request
Jun 2, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
luwes
added a commit
that referenced
this pull request
Jun 12, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
luwes
added a commit
that referenced
this pull request
Jun 13, 2025
This PR builds on top of ismapin22#12 Changes - Removed the `dist` outputs - Added a GH action to build and push the output to a new branch called `release-news-player` whenever something is pushed to the `main-news-player` branch - Fixed some build, lint issues --------- Co-authored-by: Ismael Pintos <ismaelp@qualabs.com> Co-authored-by: Christian Pillsbury <cjpillsbury@gmail.com> Co-authored-by: Ismael Pintos <126787891+ismapin22@users.noreply.github.com> Co-authored-by: Nicolas Caballero <nicolascaballero.v@gmail.com> Co-authored-by: ronalduQualabs <ronaldu@qualabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds on top of ismapin22#12
Changes
distoutputsrelease-news-playerwhenever something is pushed to themain-news-playerbranch