-
Notifications
You must be signed in to change notification settings - Fork 46
fix: <vimeo-video> element race condition
#220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
spuppo-mux
wants to merge
9
commits into
muxinc:main
Choose a base branch
from
spuppo-mux:fix/vimeo-video-element-race-condition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−35
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
14be2eb
refactored load function for readability
spuppo-mux 6a8f3dc
Moved load decoupling to the top of the function
spuppo-mux 50ef896
Added state cleanup on disconnect
spuppo-mux 359a7fc
Reset loadComplete on disconnect
spuppo-mux 4bb15ee
Merge remote-tracking branch 'upstream/main' into fix/vimeo-video-ele…
spuppo-mux adf442f
Switched approach to account for SSR and remounts
spuppo-mux 4964d42
Clean up if else chaos
spuppo-mux 6de507c
Added config old === new check to avoid unnecessary reloads; reordere…
spuppo-mux 323907f
Added connected callback
spuppo-mux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.