fix: use private field in #castPlayer getter to avoid side effects#244
Merged
ronald-urbina merged 1 commit intomuxinc:mainfrom May 6, 2026
Conversation
|
@ronald-urbina is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Jerricho93
approved these changes
May 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#castPlayergetter was callingthis.remote(the public getter)instead of
this.#remote(the private field) to look up the cast playerthis.remotehas side effects: it loads the Cast SDK and creates aRemotePlaybackinstance if one doesn't exist yetpaused,muted,volume,currentTime, etc.) was potentially triggering Cast SDK initializationunintentionally
Note
Low Risk
Low risk, one-line internal change that prevents unintended Cast SDK/
RemotePlaybackinitialization during internal property reads.Overview
Updates the
#castPlayergetter incastable-mixin.jsto reference the private#remotefield instead of the publicremotegetter, avoiding side effects like loading the Cast framework or creating aRemotePlaybackinstance during internal state access.Reviewed by Cursor Bugbot for commit 5bb675e. Bugbot is set up for automated code reviews on this repo. Configure here.