Merged
Conversation
Handle Results from db.insert() calls in tests with .unwrap(), remove
redundant & borrows in field::display() calls in main.rs, and fix
println!("") to println!().
https://claude.ai/code/session_01376NXRbNz1b9eNR2FV9dgt
- Auto-fix if-let collapsing, needless borrows, get_first, map_or simplification, io::Error::other, elided lifetimes, and more via cargo clippy --fix - Add Default impls for MemTable and SqlEngine (new() delegates) - Add MemTable::is_empty - Fix empty line in sstable.rs doc comment block - Suppress type_complexity on hints field, run_read_with_quorum return type, read_repair parameter, and parse_projection return type - Suppress too_many_arguments on run_read_with_quorum - Call repl.wait() after repl.kill() in query_grpc_test to avoid zombies https://claude.ai/code/session_01376NXRbNz1b9eNR2FV9dgt
Applies the remaining if-let collapsing, get_first, io::Error::other, and similar mechanical fixes across src/ and tests/ that were applied by cargo clippy --fix but not yet committed. https://claude.ai/code/session_01376NXRbNz1b9eNR2FV9dgt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resultfromdb.insert()calls in tests with.unwrap()&borrows infield::display()calls inmain.rs; fixprintln!("")→println!()cargo clippy --fix: if-let collapsing,get_first,map_orsimplification,io::Error::other, elided lifetimes, needless borrows, etc.Defaultimpls forMemTableandSqlEngine(delegate tonew())MemTable::is_emptysstable.rs(empty line between///sections)type_complexityonhintsfield,run_read_with_quorum,read_repair, andparse_projectiontoo_many_argumentsonrun_read_with_quorumrepl.wait()afterrepl.kill()inquery_grpc_testto avoid zombie processesTest plan
cargo clippy --testsproduces zero warningscargo testpasseshttps://claude.ai/code/session_01376NXRbNz1b9eNR2FV9dgt
Generated by Claude Code