perf_compare.sh: wait for CQL readiness on each Cassandra node#112
Merged
perf_compare.sh: wait for CQL readiness on each Cassandra node#112
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a77614b28
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ail fast on stuck nodes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a startup race in
start_cassandra_clusterwherecassandra-stresscould seeConnection refused: /172.19.0.x:9042warnings on peer nodes.Root cause
The per-node readiness check after
docker runwas onlywait_un_count $n(gossip view vianodetool status). UN ("Up Normal") flips true as soon as a node joins the gossip ring, but the CQL native transport on port 9042 binds several seconds later. Whencassandra-stressconnects to the seed and the driver opens connection pools to all peers it learned about via gossip, it races CQL startup on the just-joined peer and emits transport warnings.The seed (
cassA1) was already protected by an explicitcqlsh -e 'DESCRIBE CLUSTER'poll at line 110. The non-seed loop wasn't.Fix
Add the same
cqlsh -e 'DESCRIBE CLUSTER'poll inside thefor n in 2 3 4 5loop, afterwait_un_count. Same pattern as the seed.Test plan
scripts/perf_compare.shruns end-to-end withoutConnection refusedwarnings during the Cassandra phasecassandra-stressstartsperf-results/cassandra_*_t*.logfiles are populated as expected🤖 Generated with Claude Code