Make public things that are needed for my Grace type-checker - #6
Closed
IsaacOscar wants to merge 1 commit into
Closed
Make public things that are needed for my Grace type-checker#6IsaacOscar wants to merge 1 commit into
IsaacOscar wants to merge 1 commit into
Conversation
Author
|
I'm closing this as I've decided to go a different route, see pull request #7 which replaces this request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a few public modifiers to some classes.
This is the minimal set of changes I need for my grace type-checker.
See https://gitlab.ecs.vuw.ac.nz/isaac/GraceTC/tree/vanilla-kernan, specifically the following files:
kernan-module/kernan-parser.csprojthis is the hand-edit project file for my kernan module, which ensures the module is correctly linked with kernan and places the compiled dll in the appropriate place for kernan to find it.kernan-module/KernanParser.csthis is the source code for my module which relies on the changes in this pull request. It exposes a few methods to grace that I need for my type-checker.kernan-module/Callback.csthis provides a very simple and easy to use library for making Grace callbacks in C# code, it is a drasticly simpler version of kernans ownMethods.csfile (which defines class likeDelagateMethod1Ctx), I would suggest changedMethods.csto something like myCallback.csfile as it will allow lots of reduction of code bloat, and allow for more easily exposing methods to grace.build-kernan.shThis is a script that will download and compile my modified kernan version and build my kernan module.