Merged
Conversation
muzami1ali
approved these changes
Mar 16, 2025
Collaborator
muzami1ali
left a comment
muzami1ali
left a comment
There was a problem hiding this comment.
Everything Looks Good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new feature for generating and managing PDF documents within the
yourLifeStoryapplication. The changes include adding new views, models, serializers, and command for generating test tokens, as well as updating settings and URLs to support the new functionality.New Features:
yourLifeStory/api/views/pdf_views.py: AddedGeneratePDFViewfor generating PDFs andPDFDocumentListViewfor listing generated PDFs.yourLifeStory/media/models.py: IntroducedPDFDocumentmodel to store metadata about generated PDFs.yourLifeStory/media/serializers.py: AddedPDFDocumentSerializerfor serializingPDFDocumentinstances.yourLifeStory/yourLifeStory/urls.py: Added new URL routes for generating and viewing PDFs.Command Line Tool:
yourLifeStory/api/management/commands/generate_test_token.py: Added a management command to generate test JWT tokens for Lambda testing.Configuration:
yourLifeStory/yourLifeStory/settings.py: Added JWT settings for PDF generation and updated middleware configuration.Miscellaneous:
yourLifeStory/api/views/__init__.py: Includedpdf_viewsin the imports.yourLifeStory/media/permissions.py: Minor adjustments to permissions logic. [1] [2] [3]