Allow commands to return exit codes #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantleech
force-pushed
the
cmd-exit-codes
branch
from
5fbdc6b to
795a0e3
Compare
|
|
||
| if (($action = $this->matchedSection->getAction()) === null) { | ||
| return; | ||
| return 0; |
There was a problem hiding this comment.
what do other clis do when executing a section without the command? I'd have thought it was a 1 to signify it's not a command?
Author
There was a problem hiding this comment.
git and composer return 1. not sure when this condition gets invoked though ws config asd asd returns 1 (invalidUsage)
Author
There was a problem hiding this comment.
but yeah, the above 2 should probably be non-zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.