Fix: reuse Header instance in Cron formatter #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR ensures Cron::header() returns the same Header instance instead of creating a new one on every call. It also adds regression tests to prevent state loss when header() is called multiple times before formatting.
Motivation
header() previously reinitialised the Header each time, which could silently drop previously configured header state (e.g. PATH, MAILTO) when chaining multiple header calls. Returning a single instance makes the behaviour predictable and preserves configuration until format() is called.
What changed
Header state is preserved across multiple calls and appears in the formatted output.
Test plan & results
composer install
./vendor/bin/phpunit