fix: suppress duplicate Codex notifications#41
Merged
mylee04 merged 3 commits intomylee04:mainfrom Mar 30, 2026
Merged
Conversation
- Add has_desktop_app_running() to detect when a tool's desktop app (e.g. Codex app) is running alongside its CLI - When detected, suppress code-notify since the desktop app sends its own notifications - macOS only — uses pgrep to check for .app bundle processes - Add CODE_NOTIFY_SKIP_DESKTOP_CHECK env var for test isolation
Owner
|
Thanks for the cleanup here. This is a much better direction than the earlier broad desktop-app suppression approach, and I appreciate that you tightened it around actual Codex trigger origin instead of just checking whether the desktop app is open. The added test coverage for desktop-origin vs CLI-origin events also helps a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppress
code-notifyonly for Codex events triggered by desktop-app sessions, while keeping notifications for standalone CLI sessions.Why
Duplicate notifications happen when a Codex session is running inside the desktop app, because the desktop app already sends its own notification.
A standalone
codexCLI session should still notify, even if the desktop app is also open.Implementation
clientas the first signal for desktop-app eventsthread-idis present, resolve the thread through local Codex statesession_metaand usepayload.originatorto detectCodex DesktopCODE_NOTIFY_SKIP_CODEX_DESKTOP_CHECKTests
bash tests/test-codex-notify.shbash tests/test-notification-dedupe.sh