feat: send width height length during export - #516
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
============================================
+ Coverage 94.30% 94.32% +0.01%
- Complexity 2400 2409 +9
============================================
Files 352 352
Lines 7696 7716 +20
============================================
+ Hits 7258 7278 +20
Misses 438 438 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the shipment export payload to include package dimensions (width/height/length) alongside weight, ensuring the MyParcel API receives the full set of physical properties when available.
Changes:
- Include
length,width, andheightinphysical_propertieswhen encoding shipments for export. - Persist dimensions in
PdkPhysicalProperties::toStorableArray()so they can be stored and later re-used for exports. - Add/extend unit tests to verify dimension storage behavior (including “empty string should not become 0”).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/Unit/App/Order/Model/PdkPhysicalPropertiesTest.php | Adds coverage for dimension persistence, omission rules, and clearing behavior. |
| src/Shipment/Request/PostShipmentsRequest.php | Encodes and exports dimensions in physical_properties for shipment requests. |
| src/App/Order/Model/PdkPhysicalProperties.php | Stores dimensions and adds setters to prevent empty-string casts to 0. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FreekVR
requested changes
Aug 4, 2026
FreekVR
approved these changes
Aug 4, 2026
GravendeelJochem
requested changes
Aug 5, 2026
GravendeelJochem
approved these changes
Aug 5, 2026
myparcel-bot
Bot
force-pushed
the
feat/send-width-height-length-during-export
branch
from
August 5, 2026 09:02
a56bbf2 to
b928094
Compare
myparcel-bot
Bot
force-pushed
the
feat/send-width-height-length-during-export
branch
from
August 6, 2026 08:16
b928094 to
5a43ddb
Compare
myparcel-bot Bot
added a commit
that referenced
this pull request
Aug 6, 2026
## [4.6.0](v4.5.1...v4.6.0) (2026-08-06) ### ✨ New Features * send width height length during export ([#516](#516)) ([3431147](3431147))
Contributor
|
🎉 This PR is included in version 4.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INT-1775