fix(address-widget): pin yarn to 4.17.1 so the build runs - #1773
Merged
Conversation
The address-widget workspace pinned yarn 4.3.1 while the rest of the plugin is on 4.17.1. Its build script shells out to a nested yarn run, which then picked up 4.3.1 and refused to start, because the approvedGitRepositories setting in .yarnrc.yml only exists in newer yarn. That broke yarn build for the whole plugin. Pinning the workspace to the same 4.17.1 the plugin already uses fixes it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the checkout-address-widget workspace’s Yarn version to match the plugin’s root Yarn version, preventing workspace-local Yarn from breaking the overall build when nested yarn run is invoked.
Changes:
- Updated
views/frontend/checkout-address-widget/package.jsonto usepackageManager: yarn@4.17.1(matching the repo root).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
|
🎉 This PR is included in version 6.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pins the address-widget workspace to yarn 4.17.1 so the plugin build runs again.
The address-widget workspace pinned yarn 4.3.1 while the rest of the plugin is on 4.17.1. Its build script shells out to a nested
yarn run, which then picked up 4.3.1 and refused to start, because theapprovedGitRepositoriessetting in.yarnrc.ymlonly exists in newer yarn. That brokeyarn buildfor the whole plugin, not just this workspace.Pinning the workspace to the same 4.17.1 the plugin already uses fixes it. No lockfile change needed, and
yarn install --immutablestays green.🤖 Generated with Claude Code