Fix unsafe directory iteration in ConfigReader#10
Conversation
- Add existence and directory checks before listing directory contents. - Log warning if directory is invalid instead of crashing. - Add tests for ConfigReader. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Configure mock SparkSession in tests/test_integration.py to return integer for count() and boolean for database existence checks. - This fixes the CI failure where MagicMock comparisons caused TypeError. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
1 participant
This PR fixes a code health issue in
ConfigReader.pywhere listing a non-existent directory would raise an exception. It now checks for directory existence and logs a warning if invalid, ensuring safer execution. It also adds unit tests to verify this behavior.PR created automatically by Jules for task 6604387740783920240 started by @mysticBliss