🔒 Fix unrestricted configuration file loading in ConfigReader#11
🔒 Fix unrestricted configuration file loading in ConfigReader#11mysticBliss wants to merge 2 commits into
Conversation
Modified `datamov/core/config_reader/ConfigReader.py` to support file pattern filtering and added robust error handling for JSON loading. Updated `datamov/core/data_movements/DataMovements.py` to enforce a restrictive file pattern, ensuring only expected configuration files are loaded. This addresses a security vulnerability where `ConfigReader` would blindly load all JSON files in a directory. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Patched DataProcessor and Validator in `tests/test_integration.py` to fix a TypeError caused by MagicMock comparisons. This ensures the test runs correctly in the CI environment where pyspark is globally mocked. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
1 participant
This PR addresses a security vulnerability in
ConfigReaderwhere it would load all JSON files in a given directory without restriction.Changes:
datamov/core/config_reader/ConfigReader.py:file_patternargument to__init__to allow filtering files by regex.read_json_filesusing the provided pattern.try...exceptblock aroundjson.loadto handleJSONDecodeErrorandIOErrorgracefully, logging errors instead of crashing.datamov/core/data_movements/DataMovements.py:ConfigReaderinstantiation to use a strict pattern:r'^(data_movements_|environment_).*\.json$'.Verification:
PR created automatically by Jules for task 1735583669634676966 started by @mysticBliss