refactor: Remove broken and unused Logger config method#12
Conversation
Removes the unused `add_config` method and `self.config` initialization from `datamov/core/logger/Logger.py`. Adds `tests/test_logger.py` to cover `Logger` functionality including Singleton behavior, log level setting, and initialization idempotency. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removes the unused `add_config` method and `self.config` initialization from `datamov/core/logger/Logger.py`. Adds `tests/test_logger.py` to cover `Logger` functionality including Singleton behavior, log level setting, and initialization idempotency. Fixes `tests/test_integration.py` to properly mock `DataFrame.count()` and verify Spark write operations in CI environments where PySpark is mocked. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
1 participant
This PR addresses a code health issue where the
Loggerclass contained a broken and unusedadd_configmethod.Changes:
add_configmethod fromLoggerclass.self.configinitialization fromLogger.__init__.tests/test_logger.pyfor theLoggerclass.Verification:
tests/test_logger.pyand confirmed all tests passed.PR created automatically by Jules for task 3325395187735312655 started by @mysticBliss