Skip to content

Fix logic and robustness of DataFlow._subtract_month#13

Open
mysticBliss wants to merge 5 commits into
mainfrom
fix/dataflow-subtract-month-logic-2013603253886078263
Open

Fix logic and robustness of DataFlow._subtract_month#13
mysticBliss wants to merge 5 commits into
mainfrom
fix/dataflow-subtract-month-logic-2013603253886078263

Conversation

@mysticBliss

Copy link
Copy Markdown
Owner

This PR addresses critical issues in DataFlow._subtract_month:

  1. Logic Fix: Corrected the year calculation formula when subtracting months that result in a previous year. The original code used year - y, which erroneously increased the year when y was negative. It is now year + y.
  2. Robustness: Added handling for month-end dates. Previously, subtracting a month from a date like March 31st would crash with ValueError if the previous month had fewer days. The new implementation clamps the day to the last valid day of the target month using calendar.monthrange.
  3. Testing: Expanded tests/test_data_flow.py with unit tests covering normal subtraction, year wrap-around, and month-end edge cases.

PR created automatically by Jules for task 2013603253886078263 started by @mysticBliss

…tness

Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

google-labs-jules Bot and others added 4 commits February 19, 2026 06:41
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant