Fix logic and robustness of DataFlow._subtract_month#13
Conversation
…tness Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
This PR addresses critical issues in
DataFlow._subtract_month:year - y, which erroneously increased the year whenywas negative. It is nowyear + y.ValueErrorif the previous month had fewer days. The new implementation clamps the day to the last valid day of the target month usingcalendar.monthrange.tests/test_data_flow.pywith unit tests covering normal subtraction, year wrap-around, and month-end edge cases.PR created automatically by Jules for task 2013603253886078263 started by @mysticBliss