Add unit test for DataProcessor.save_data parameter validation#29
Add unit test for DataProcessor.save_data parameter validation#29mysticBliss wants to merge 2 commits into
Conversation
Added `tests/test_data_processor.py` to verify that `save_data` correctly handles missing `table_name` when `format_type` is "hive", ensuring it logs an error and returns failure status. Also added a test for the valid case. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fixed `DataMovements.py` attribute error by using `self._environments` and `environment_configs`. - Updated `DataFlow.py` to correctly handle simple `strftime` strings without `eval`, fixing `test_data_flow_paths.py`. - Updated `tests/test_data_movements.py` to use public property `environment_configs`. - Patched `lit` in `tests/test_integration.py` to avoid importing from broken/partial `pyspark` installation in CI. - Fixed `test_integration.py` assertion to verify calls on the correct mock object returned by side_effect. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
1 participant
Added unit tests to
tests/test_data_processor.pycovering:test_save_data_hive_missing_table_name: Verifies thatValueErroris caught, logged as an error, and returnsstatus=Falsewhentable_nameis missing for Hive format.test_save_data_hive_valid: Verifies thatsaveAsTableis called correctly whentable_nameis provided for Hive format.These tests improve coverage for
DataProcessor.save_datavalidation logic.PR created automatically by Jules for task 8329399052790993349 started by @mysticBliss