🧪 Fix DataMovements bug and test deprecated method#32
Conversation
- Fixed AttributeError in DataMovements._process_environment_config by changing self.environments to self._environments. - Updated tests/test_data_movements.py to verify against dm.environment_configs instead of non-existent dm.environments. - Added test_load_data_movements_deprecated to verify that load_data_movements calls load_configs. Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
mysticBliss
deleted the
testing-improvement-datamovements-deprecated-17971591082100045194
branch
1 participant
This PR addresses a testing gap by adding a test for the deprecated
load_data_movementsmethod.Additionally, it fixes a bug discovered during testing where
DataMovementswas attempting to access a non-existentenvironmentsattribute.The existing test was also updated to check the correct property
environment_configs.Changes:
datamov/core/data_movements/DataMovements.py: Changedself.environmentstoself._environments.tests/test_data_movements.py: Changeddm.environmentstodm.environment_configsand addedtest_load_data_movements_deprecated.PR created automatically by Jules for task 17971591082100045194 started by @mysticBliss