Skip to content

Improve exception handling in Engine tracking logic#33

Merged
mysticBliss merged 1 commit into
mainfrom
code-health-engine-tracking-exception-5194203951055708408
Feb 26, 2026
Merged

Improve exception handling in Engine tracking logic#33
mysticBliss merged 1 commit into
mainfrom
code-health-engine-tracking-exception-5194203951055708408

Conversation

@mysticBliss

Copy link
Copy Markdown
Owner

This PR addresses a code health issue in datamov/core/engine/Engine.py where exceptions during the saving of tracking information were logged without a traceback, making debugging difficult.

Changes:

  1. Modified datamov/core/engine/Engine.py:

    • Changed logger.error("Failed to save tracking info: {}".format(e)) to logger.error("Failed to save tracking info", exc_info=True). This ensures the full stack trace is logged.
    • Removed df_tracking.select('dm_etl_uuid', 'load_status').show() to clean up stdout from debug prints.
    • Removed unused variable e in the except block.
  2. Updated tests/test_engine.py:

    • Added test_tracking_exception_logging to verify that logger.error is called with exc_info=True when an exception occurs during tracking dataframe creation.

Verification:

  • Run PYTHONPATH=. pytest tests/test_engine.py - Passed.
  • Verified that tests/test_integration.py failures are unrelated to these changes.

PR created automatically by Jules for task 5194203951055708408 started by @mysticBliss

- Use `exc_info=True` in `logger.error` to log full tracebacks for exceptions during tracking info save.
- Remove `df_tracking.select(...).show()` to eliminate unnecessary debug output in production.
- Add unit test `test_tracking_exception_logging` in `tests/test_engine.py` to verify proper exception logging.

Co-authored-by: mysticBliss <11345806+mysticBliss@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@mysticBliss mysticBliss merged commit c4e275a into main Feb 26, 2026
0 of 2 checks passed
@mysticBliss mysticBliss deleted the code-health-engine-tracking-exception-5194203951055708408 branch February 26, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant