Fix some minor issues

sql-migrations/all/2024-07-16-00-33-13-create-statistics.sql

@@ -1,11 +1,13 @@
-CREATE STATISTICS IF NOT EXISTS test_stat_expr
-    ( dependencies,mcv) ON employee_id, lower(employee_name)
-    FROM employee ;
-CREATE STATISTICS IF NOT EXISTS test_stat
-    ( dependencies,ndistinct,mcv) ON employee_id, employee_name
-    FROM employee ;
-
-CREATE STATISTICS IF NOT EXISTS test_stat_with_expr
-    ( dependencies,ndistinct,mcv) ON id, (lower(popular_name)), popular_name, (id*42)
-    FROM animals;
-
+-- This file has CRLF line endings, just another test
+-- 
+CREATE STATISTICS IF NOT EXISTS test_stat_expr
+    ( dependencies,mcv) ON employee_id, lower(employee_name)
+    FROM employee ;
+CREATE STATISTICS IF NOT EXISTS test_stat
+    ( dependencies,ndistinct,mcv) ON employee_id, employee_name
+    FROM employee ;
+
+CREATE STATISTICS IF NOT EXISTS test_stat_with_expr
+    ( dependencies,ndistinct,mcv) ON id, (lower(popular_name)), popular_name, (id*42)
+    FROM animals;
+

src/Codd/AppCommands/AddMigration.hs

@@ -212,8 +212,12 @@ addMigration dbInfo@Codd.CoddSettings {onDiskReps, migsConnString = defaultConnI
                             (pgMajorVer, _) <- queryServerMajorAndFullVersion conn
                             (pgMajorVer,) <$> readRepresentationsFromDbWithSettings dbInfo conn
                         )
-                    addedMigRequiresCoddSchema <- liftIO $ checkCoddSchemaFunctionsHaveBeenCalled listenConn
+                    -- Different connections means different sockets, which means we have to fetch
+                    -- some query results _before_ `checkCoddSchemaFunctionsHaveBeenCalled`, because
+                    -- that checks if a notification was received non-blocking, and that can return
+                    -- no notifications unless we fetch something on "listenConn" first.
                     newlyStartedJobs <- getAddedJobsStillRunning listenConn maxBackgroundJobIdBefore
+                    addedMigRequiresCoddSchema <- liftIO $ checkCoddSchemaFunctionsHaveBeenCalled listenConn
                     closeFileStream migStream
                     pure (pgVerAndSchemas, addedMigRequiresCoddSchema, newlyStartedJobs)
                 persistRepsToDisk pgMajorVer databaseSchemas onDiskRepsDir

test/DbDependentSpecs/BackgroundJobsSpec.hs

@@ -219,7 +219,7 @@ spec = do
                     lastRunAt startedCoddJob `shouldNotBe` Nothing
                     completedOrAbortedAt startedCoddJob `shouldBe` Nothing
                     finalizedAt startedCoddJob `shouldBe` Nothing
-              (allEmployees :: [(String, String)], finalizedCoddJob :: JobInfo, scheduledCronJobs :: [String]) <-
+              (allEmployees :: [(String, String)], finalizedCoddJob :: JobInfo, scheduledCronJobs :: [DB.Only String]) <-
                 applyMigrationsNoCheck
                   testDbInfo {txnIsolationLvl = txnIsolationLvl}
                   (Just [finalizeExperienceMigration])
@@ -274,7 +274,7 @@ spec = do
             -- it to conflict with itself.
             -- The call to applyMigrationsNoCheck below deadlocks unless codd's schema has carefully designed locks
             -- in its functions.
-            (allEmployees :: [(String, String)], finalizedCoddJob :: JobInfo, scheduledCronJobs :: [String]) <-
+            (allEmployees :: [(String, String)], finalizedCoddJob :: JobInfo, scheduledCronJobs :: [DB.Only String]) <-
               applyMigrationsNoCheck
                 testDbInfo {txnIsolationLvl = txnIsolationLvl}
                 (Just [finalizeExperienceMigration])