fix(server): declare UTF-8 for SPA HTML responses#4
Closed
mzkarami wants to merge 1 commit into
Closed
Conversation
Owner
Author
|
Closing this fork draft after review: the change overlaps existing upstream encoding PRs (paperclipai#3041/paperclipai#3557/paperclipai#4427), so it is not worth submitting upstream as-is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
text/html; charset=utf-8.text/html; charset=utf-8.Ærøskøbing blåbærgrød).Verification
git diff --checkpnpm exec vitest run server/src/__tests__/static-index-html.test.tspnpm --filter @paperclipai/server typecheckPRworkflow succeeded for head3ce04701b1b1ad068fc1a1d08cd31c79efdc0a6dRisks
Model Used
gpt-5.5, with repository file access, shell command execution, and GitHub CLI tool use.Checklist
Public discovery / duplicate checks
charset utf-8 html Danish encoding,UTF-8 OR utf8 OR charset OR Danish OR encoding.server/src/app.tsSPA fallback HTML content-type headers.Human gate
This is a fork draft prepared for human review only. Upstream submission requires explicit human approval in a separate interactive session. Current recommendation: do not submit upstream as-is because of duplicate/overlap risk.