Skip to content

fix(server): declare UTF-8 for SPA HTML responses#4

Closed
mzkarami wants to merge 1 commit into
masterfrom
auto/nightly-paperclip-charset-utf8-20260602
Closed

fix(server): declare UTF-8 for SPA HTML responses#4
mzkarami wants to merge 1 commit into
masterfrom
auto/nightly-paperclip-charset-utf8-20260602

Conversation

@mzkarami

@mzkarami mzkarami commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Thinking Path

What Changed

  • Set the static SPA fallback response type to text/html; charset=utf-8.
  • Set the Vite dev HTML response type to text/html; charset=utf-8.
  • Added a regression test that verifies fallback HTML declares UTF-8 and preserves Danish text (Ærøskøbing blåbærgrød).

Verification

  • git diff --check
  • pnpm exec vitest run server/src/__tests__/static-index-html.test.ts
  • pnpm --filter @paperclipai/server typecheck
  • Fork PR CI PR workflow succeeded for head 3ce04701b1b1ad068fc1a1d08cd31c79efdc0a6d

Risks

For core feature work, check ROADMAP.md first and discuss it in #dev before opening the PR. Feature PRs that overlap with planned core work may need to be redirected — check the roadmap first. See CONTRIBUTING.md.

Model Used

  • OpenAI Codex via Hermes Agent, model gpt-5.5, with repository file access, shell command execution, and GitHub CLI tool use.

Checklist

  • I have included a thinking path that traces from project context to this change
  • I have specified the model used (with version and capability details)
  • I have checked ROADMAP.md and confirmed this PR does not duplicate planned core work
  • I have run tests locally and they pass
  • I have added or updated tests where applicable
  • If this change affects the UI, I have included before/after screenshots
  • I have updated relevant documentation to reflect my changes
  • I have considered and documented any risks above
  • I will address all Greptile and reviewer comments before requesting merge

Public discovery / duplicate checks

Human gate

This is a fork draft prepared for human review only. Upstream submission requires explicit human approval in a separate interactive session. Current recommendation: do not submit upstream as-is because of duplicate/overlap risk.

@mzkarami

mzkarami commented Jun 2, 2026

Copy link
Copy Markdown
Owner Author

Closing this fork draft after review: the change overlaps existing upstream encoding PRs (paperclipai#3041/paperclipai#3557/paperclipai#4427), so it is not worth submitting upstream as-is.

@mzkarami mzkarami closed this Jun 2, 2026
@mzkarami mzkarami deleted the auto/nightly-paperclip-charset-utf8-20260602 branch June 2, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant