chore: Update PR template for API changes - #4507
Merged
Merged
Conversation
This aligns with a change started in noq: - Mention API changes rather than breaking changes. - Do not encourage to remote checkboxes. That leaves me guessing what the template *should* look like in each repo.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/4507/docs/iroh/ Last updated: 2026-09-04T14:01:56Z |
flub
enabled auto-merge
September 4, 2026 14:02
matheus23
approved these changes
Sep 4, 2026
matheus23
left a comment
matheus23
left a comment
Member
There was a problem hiding this comment.
I'd have like a super minor nit about being clearer about "API Changes" only being optional when there are no API changes, but 🤷♂️ I'm fine with it as-is, and it'd align with what we have in noq.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This aligns with a change started in noq:
Mention API changes rather than breaking changes.
Do not encourage to remote checkboxes. That leaves me guessing what
the template should look like in each repo.
Breaking Changes
n/a
Notes & open questions
Equivalent noq pr: n0-computer/noq#796
Change checklist
proposed change and wrote an as clear and concise description as
they could.
intented effect.