fix: make cancel operation durable — prevent feeders from overwriting CANCELLED status#43
Open
ChefControl wants to merge 1 commit into
Open
fix: make cancel operation durable — prevent feeders from overwriting CANCELLED status#43ChefControl wants to merge 1 commit into
ChefControl wants to merge 1 commit into
Conversation
Feeders that were mid-processing would overwrite CANCELLED status back to COMPLETED and continue creating new PENDING children, effectively undoing the cancel operation. This fixes the race in two ways: 1. Add WHERE n.job_status <> 'CANCELLED' guard to update_job_status so the Cypher SET is a no-op when the cancel operation already fired. 2. Re-check is_cancelled() right before batch_create_children() to prevent new PENDING children from being created after cancellation. Closes #20 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WHERE n.job_status <> 'CANCELLED'guard toupdate_job_statusso feeders can no longer overwrite CANCELLED back to COMPLETEDis_cancelled()right beforebatch_create_children()to prevent new PENDING children from being created after cancellationTest plan
https://wikipedia.orgat depth 5)DELETE /api/v1/crawls/:idcancelledcount reflects the cancelled URLsCloses #20
🤖 Generated with Claude Code