Skip to content

Make file metrics collection more failsafe #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cubiwynants wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make file metrics collection more failsafe #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/main/java/be/nabu/eai/server/CollaborationListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,6 @@ public Void handle(ResourceEvent event) {
}
});

final List<FileStore> filestores = SystemMetrics.filestores();
final MemoryMXBean memoryMXBean = ManagementFactory.getMemoryMXBean();
final OperatingSystemMXBean operatingSystemMXBean = ManagementFactory.getOperatingSystemMXBean();
// push server statistics to the developers
Expand All @@ -164,13 +163,14 @@ public void run() {
// MemoryUsage nonHeapMemoryUsage = memoryMXBean.getNonHeapMemoryUsage();
// metrics.add(new ServerStatistic("memory", "nonHeap", date.getTime(), ((100.0 * nonHeapMemoryUsage.getUsed()) / nonHeapMemoryUsage.getMax())));

for (FileStore store : filestores) {
// Refresh filestores each cycle so disconnected mounts are skipped
for (FileStore store : SystemMetrics.filestores()) {
try {

metrics.add(new ServerStatistic("file", store.name(), date.getTime(), (((1.0 * (store.getTotalSpace() - store.getUsableSpace())) / store.getTotalSpace()) * 100)));
}
catch (IOException e) {
logger.warn("Can't read file statistics for " + store.name(), e);
// Some mounts can disappear between sampling cycles; avoid noisy stack traces
logger.debug("Skipping file statistics for {}: {}", store.name(), e.getMessage());
}
}
statistics.setStatistics(metrics);
Expand Down