refactor: Unify coding style across Rust and Python#110
Merged
Conversation
- Move function-level use statements to module top level in non-test code - Replace fully qualified paths with top-level imports (tracing macros and derive/attribute macros excluded) - Add DesiredCondition::condition_type_name() to eliminate hardcoded condition type strings in evaluate.rs - Add tests for condition_type_name() using macro_rules
- Use keyword arguments for all PyO3 binding and internal function calls - Replace hardcoded output format strings with FORMAT_JSON/FORMAT_TEXT constants in output.py - Update test assertions to match kwargs calling convention
- Rust: top-level use, no fully qualified paths (tracing macros excepted), derive values from enums instead of hardcoding strings - Python: kwargs for all function calls, named constants for fixed values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useto module top level, replace fully qualified paths with top-level imports, derive condition type strings fromDesiredConditionenum instead of hardcodingFORMAT_JSON/FORMAT_TEXTconstants