Repository navigation
✨ feat: ypm 状态开放封面与 seek - #31
Merged
Merged
Conversation
为 GUI/TUI 共用的 ypm 控制协议增加可选封面、seek 能力和图标模式;封面只开放净化后的网易云 HTTPS 小图地址,旧客户端缺省字段仍可读取。
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c0f17a73cc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
用当前 player generation 标记实际就绪状态;加载中、结束或失败的曲目不再宣告 seekable,GUI/TUI CLI 也会在发命令前拒绝不可跳转的快照。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目的
给外部 TUI 集成一个稳定、只读状态 + 有界控制的公共 CLI 面,不要求调用方读取 YPM 私有 socket 或改播放器内部状态。首个调用方是
dsh-music-tui。改动
ypm --json --tui status增量返回coverUrl、seekable、iconStyleypm seek <seconds>通过现有控制协议对 GUI/TUI 执行绝对 seekAction::SeekToRatio,不会新增第二套播放状态seekable只在当前曲目 generation 已收到PlayerEvent::Started且有时长时开放;换曲、结束或失败都会复位,CLI 与 reducer 也会拒绝未就绪的 seek*.music.126.net,强制 HTTPS、去凭据/旧 query,并限制到 64×64不自动启动或接管 YPM;播放器仍由用户在后台运行。
验证
cargo fmt --all -- --checkcargo test --workspace(全部通过)cargo clippy --workspace --all-targets -- -D warningsbun run typecheckbun run build:tauri:renderergit diff --checkbun test为 438 PASS / 1 个既有 TLS fixture FAIL:test/webviewProxyRelay.test.ts的 HTTPS proxy 用仅签发给 localhost 的证书验证 outside.invalid;本 PR 未改该测试或 relay 路径。提交因此在上述门禁手工完成后使用--no-verify,没有隐藏功能相关失败。相关宿主图片接口:ccch1mneyyy/dsh-TUI#661
插件仓库:https://github.com/Nagi-ovo/dsh-music-tui