Added broadcast_message_scoped to allow sending messages only to users with a specific entity in their scope#167
Open
Jeff425 wants to merge 1 commit into
Open
Added broadcast_message_scoped to allow sending messages only to users with a specific entity in their scope#167Jeff425 wants to merge 1 commit into
Jeff425 wants to merge 1 commit into
Conversation
…s with a specific entity in their scope
Jeff425
commented
May 10, 2023
| } | ||
|
|
||
| pub fn get(&self, user_key: &UserKey, entity: &E) -> Option<&bool> { | ||
| pub fn get(&self, user_key: &UserKey, entity: &E) -> bool { |
Author
There was a problem hiding this comment.
I updated this function to return a bool instead of an option of a borrowed bool.
Let me know if there is a use-case for this function returning None instead of just false.
Jeff425
commented
May 10, 2023
| } | ||
|
|
||
| pub fn insert(&mut self, user_key: UserKey, entity: E, in_scope: bool) { | ||
| if self.main_map.contains_key(&(user_key, entity)) { |
Author
There was a problem hiding this comment.
Added in this check to see if the scope is just being updated rather than inserted.
If the user/entity key already existed in the main_map, then we should be able to assume that we just need to update main_map to the new boolean value
Jeff425
commented
May 10, 2023
| } else { | ||
| false | ||
| }; | ||
| let should_be_in_scope = self.entity_scope_map.get(user_key, entity); |
Author
There was a problem hiding this comment.
Updated to take advantage of get returning just a bool instead of an option of a borrowed bool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@connorcarpenter I noticed it didn't seem possible to broadcast a message to users with a specific entity in their scope. This PR is my attempt to add that feature.