Fix dependency audit findings, lint errors, and contact move authorization#147
Open
jhilly20 wants to merge 15 commits into
Open
Fix dependency audit findings, lint errors, and contact move authorization#147jhilly20 wants to merge 15 commits into
jhilly20 wants to merge 15 commits into
Conversation
Co-authored-by: justinhillstrom@proton.me <justinhillstrom@proton.me>
…cal-review-fixes * fix dependency audit findings * allow vite patch updates --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…-fixes * Fix frontend lint errors * Preserve verification loading on effect reruns --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Owner
|
This PR currently has merge conflicts against main. GitHub reports mergeable=CONFLICTING and mergeStateStatus=DIRTY. Please rebase or merge the latest main and resolve the conflicts before further review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR applies the completed technical-review fixes from the fork:
golang.org/x/*modules, and adding Bun overrides for vulnerable frontend transitive dependencies.Verification
govulncheck ./...reports 0 called vulnerabilities.bun auditreports 0 vulnerabilities.make build-serverpasses.make build-webpasses.make lintpasses.make testpasses.Security notes for maintainer review
A higher-severity relationship IDOR concern was found during the authorization audit but intentionally left for separate maintainer review:
related_contact_idvalues that are validated as existing contacts, but should also be explicitly checked against vaults the user can access.Contact-move child-data semantics were also intentionally left unchanged:
vault_id.contact_id.vault_id.Fork PR context
These changes were reviewed separately in the fork before combining upstream: