Revert "deps(demo)(deps): bump gradle-wrapper from 8.11.1 to 9.4.1 in /anchorpq-demo-app"#114
Conversation
… /anchorpq-demo-app"
There was a problem hiding this comment.
Pull request overview
Reverts a previous Gradle wrapper upgrade by adjusting wrapper scripts and wrapper distribution URLs (and reintroducing wrapper JARs) to bring the repo/demo app back to earlier Gradle versions.
Changes:
- Update root wrapper scripts (
gradlew,gradlew.bat) to use an explicitCLASSPATHand invokeorg.gradle.wrapper.GradleWrapperMain. - Downgrade wrapper
distributionUrl(root to8.11.1, demo app to9.3.1). - Add/restore
gradle-wrapper.jarfor both the root wrapper and the demo app wrapper.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
gradlew.bat |
Switch wrapper invocation to -classpath + GradleWrapperMain with CLASSPATH var. |
gradlew |
Update wrapper script template content and Java invocation; introduces a critical syntax issue to fix. |
gradle/wrapper/gradle-wrapper.properties |
Set root Gradle distribution to 8.11.1-all. |
gradle/wrapper/gradle-wrapper.jar |
Add/restore root wrapper JAR binary. |
anchorpq-demo-app/gradlew |
Update template reference URL to HEAD. |
anchorpq-demo-app/gradle/wrapper/gradle-wrapper.properties |
Set demo app Gradle distribution to 9.3.1-all. |
anchorpq-demo-app/gradle/wrapper/gradle-wrapper.jar |
Add/restore demo app wrapper JAR binary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Collect all arguments for the java command: | ||
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | ||
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, |
There was a problem hiding this comment.
The comment lists JAVA_OPTS twice: DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar.... This looks like a copy/paste typo; remove the duplicate to avoid confusion when reading the wrapper script.
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, | |
| # * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS are not allowed to contain shell fragments, |
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-all.zip |
There was a problem hiding this comment.
The PR title/description says this reverts a Gradle wrapper bump (8.11.1 → 9.4.1) in /anchorpq-demo-app, but this change sets the demo app wrapper to 9.3.1. If the intent is a full revert, update the distributionUrl accordingly (or adjust the PR title/description to reflect the actual target version).
| APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s | ||
| ' "$PWD" ) || exit |
There was a problem hiding this comment.
The APP_HOME assignment is broken because the printf format string is split across two lines (printf '%s then newline then ' "$PWD"). This will cause a POSIX shell syntax error and prevent the wrapper from running. Collapse it back to a single line with printf '%s\n' "$PWD" (matching the standard Gradle wrapper script).
| APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s | |
| ' "$PWD" ) || exit | |
| APP_HOME=$( cd -P "${APP_HOME:-./}" > /dev/null && printf '%s\n' "$PWD" ) || exit |
Reverts #90