Conversation
stas-nc
requested review from
b1ff,
blackrabbit99,
harnyk,
m2broth,
wRLSS and
yehor-manzhula
yehor-manzhula
approved these changes
Feb 3, 2025
Contributor
|
Could u please create PR targeting this branch inside ILC to ensure all tests are green also there |
Member
Author
I'm not able to do it until this PR is merged. I applied the necessary changes in ILC, but PR should be after merge. |
wRLSS
approved these changes
Feb 4, 2025
|
|
||
| const urlObj = new URL(uri); | ||
| origin = urlObj.origin; | ||
| if (normalizedUri.startsWith('/')) { |
Contributor
There was a problem hiding this comment.
how would it work for cases my-url/1 when it starts not from /
Member
Author
There was a problem hiding this comment.
It will go by default route through new URL() call. Do we want to put more strict matching by protocol?
Contributor
There was a problem hiding this comment.
I think so because it would be a surprise next time for whom will use such URLs
blackrabbit99
approved these changes
Feb 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.