Improve how the ENSRainbow client handles network errors #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djstrong
commented
Mar 6, 2025
| logger.debug(`Heal result:`, result); | ||
| return c.json(result, result.errorCode); | ||
|
|
||
| // Map error codes > 1000 to 500, otherwise use the original code |
djstrong
commented
Mar 6, 2025
| if ( | ||
| errorMessage.toLowerCase().includes("network") || | ||
| errorMessage.toLowerCase().includes("failed to fetch") || | ||
| errorMessage.toLowerCase().includes("fetch failed") |
tk-o
reviewed
Mar 13, 2025
| return c.json(result, result.errorCode); | ||
|
|
||
| // Map error codes > 1000 to 500, otherwise use the original code | ||
| const statusCode = result.errorCode && result.errorCode >= 1000 ? 500 : result.errorCode; |
Contributor
There was a problem hiding this comment.
Can result.errorCode >= 100 be ever true? We haven't changed anything int the server code, so it won't know about new error codes.
Contributor
Author
There was a problem hiding this comment.
There are new error codes defined:
// Network error codes
TIMEOUT: 1000,
NETWORK_OFFLINE: 1001,
GENERAL_NETWORK_ERROR: 1099,
tk-o
reviewed
Mar 13, 2025
Collaborator
|
next steps: merge main & re-review |
shrugs
approved these changes
Apr 2, 2025
Collaborator
shrugs
left a comment
shrugs
left a comment
There was a problem hiding this comment.
I'm concerned that the error handling here is slightly overly specified but not worth refactoring — LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#213