Add option to continue scroll when leaving scroll ref#1029
Open
AlbinLind wants to merge 3 commits into
Open
Conversation
We only need the pointer capture if we are actually moving
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Number
Currently when scrolling through dragging with the mouse and you leave the timeline div it stops scrolling. When the timeline is a small part of the page with only very few groups that are not very high this is very annoying.
Overview of PR
The PR adds a prop option (
continueDragOnMouseLeave) to the main timeline object that makes theScrollElementcapture the pointer event if it is set to true. This allows us to follow the mouse movement outside of the timeline DOM which gives smoother and more predictable scrolling behaviour. By default this option is disables, which means behaviour is by default the same as before.