[codex] Stabilize reactions build and install docs#15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dist/reactions-pool.jsondeterministic by collecting source reaction pools directly, deduping, and sorting before writing the artifact.Validation
bun test-> 319 pass, 0 failbun run buildtwice ->dist/reactions-pool.jsonSHA-256 stayed4fc02c0d6a9cdd9a14fca0dacf0260d29b18f38c2293259dbdc4a4f867361d51NPM_CONFIG_CACHE=/private/tmp/petsonality-npm-cache npm pack --dry-run-> package contains expected 15 files, includingdist/reactions-pool.jsonanddist/server.jsNotes
Windows smoke testing remains intentionally out of scope for this PR.