Upgrade node-pty to 1.2.0-beta.15 (macOS spawn-helper exec-bit fix) - #48
Merged
Conversation
… fix 1.1.0 ships prebuilds/darwin-*/spawn-helper with mode 644, so macOS PTY spawn fails with posix_spawnp EACCES (microsoft/node-pty#850). The permission fix landed upstream in #858; pin ~1.2.0-beta.15 (prereleases only, no silent jump to a future 1.3.0). spawn/onData/onExit/write/ kill/resize API is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
macOS で PTY spawn が
Error: posix_spawnp failed.で失敗する不具合の修正。node-pty@1.1.0 の npm tarball に含まれる
prebuilds/darwin-*/spawn-helperが実行権限なし (644) で配布されており、権限を保持して展開する環境で
spawn-helper を exec できず失敗する (microsoft/node-pty#850)。権限修正は
上流 PR #858 で入っており、1.2.0-beta.15 の tarball では 755 で収録済み。
Changes
server/package.json:node-ptyを^1.1.0→~1.2.0-beta.15に変更^1.1.0は prerelease (1.2.0-beta.*) を解決対象に含まないため明示指定が必須~1.2.0-beta.15は prerelease のみに固定 (将来の正式リリースへの自動移行なし)package-lock.json: npm install による自動更新 (node-addon-api 7.1.1 含む)コード変更なし:
spawn/onData/onExit/write/kill/resizeの API は1.1.0 と同一、
encodingデフォルト'utf8'も不変。Tests
npm test: 345 pass / 0 fail (従来と同数)node -e "require('node-pty').spawn('/bin/echo',['smoke'])"が onExit まで正常完了