Skip to content

ci: detect Dependabot PRs via PR author, not github.actor#70

Merged
nanasess merged 1 commit into
mainfrom
ci/fix-dependabot-skip-condition
Jun 2, 2026
Merged

ci: detect Dependabot PRs via PR author, not github.actor#70
nanasess merged 1 commit into
mainfrom
ci/fix-dependabot-skip-condition

Conversation

@nanasess
Copy link
Copy Markdown
Owner

@nanasess nanasess commented Jun 2, 2026

Summary

Fix the Dependabot skip condition on the claude-review job. The previous condition added in #69if: github.actor != 'dependabot[bot]' — did not actually skip the job on Dependabot PRs.

Why the previous fix did not work

Observed on PR #67: after #69 was merged, the claude-review run still failed instead of being skipped.

github.actor is whoever triggered the run, not the PR author. Merging #69 into main caused Dependabot to automatically rebase #67, which fired a synchronize event — but because that rebase was triggered by the human merge, GitHub attributed the run's github.actor / triggering_actor to nanasess, not dependabot[bot]. So 'nanasess' != 'dependabot[bot]' evaluated to true, the job ran (not skipped), and failed the workflow-file validation with 401 as before.

Fix

Use the PR author, which stays dependabot[bot] regardless of who triggers the run:

if: github.event.pull_request.user.login != 'dependabot[bot]'

A comment explaining the github.actor pitfall is included so it is not "fixed back" later.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • GitHub ActionsワークフローのDependabotプルリクエスト検出ロジックを改善しました。

前回の `if: github.actor != 'dependabot[bot]'` は意図どおり動かなかった。
github.actor は「実行を引き起こしたユーザー」を指すため、別 PR をマージして
Dependabot PR が自動 rebase された際、実行が人間(マージした本人)に帰属し
スキップされなかった。PR 作成者を見る pull_request.user.login で判定すれば、
誰が再実行を誘発しても Dependabot PR を安定して識別できる。

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 2, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b19c384c-0f7f-4043-896d-5fa25e54a4aa

📥 Commits

Reviewing files that changed from the base of the PR and between 8f7b03f and 0b08ea8.

📒 Files selected for processing (1)
  • .github/workflows/claude-code-review.yml

📝 Walkthrough

Walkthrough

GitHub Actions ワークフロー内でDependabot由来のプルリクエストをスキップするための条件が、github.actorからgithub.event.pull_request.user.loginへ変更されました。あわせて関連するコメントも更新されています。

Changes

Dependabot PR検出条件の更新

Layer / File(s) Summary
Dependabot検出条件の更新
.github/workflows/claude-code-review.yml
ワークフローのif条件が、より正確なPR作成者情報であるgithub.event.pull_request.user.loginを用いてDependabotを検出するように変更されました。判定ロジックおよび関連するコメントが同期更新されています。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Dependabotの化身を見極める道を
github.actorからuser.loginへ変え
ワークフローの心はより正しく輝き
自動更新の歓声が聞こえる
小さな修正が大きな真実へ ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PRのタイトルは、主な変更点であるDependabot PR検出ロジックの修正(github.actorからPR作成者ログインへの変更)を正確に要約しており、明確で簡潔です。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/fix-dependabot-skip-condition

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nanasess nanasess merged commit edc40fb into main Jun 2, 2026
56 of 57 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

🚀 Performance Benchmark Results

Benchmark executed on merge to main branch from PR #70

Configuration

  • Iterations per test: 10,000
  • PHP Version: 8.2
  • Extension: bcmath (native) vs polyfill

Results

📊 Detailed Benchmark Results (click to expand)

BCMath Performance Benchmark Results

Operation Context Native Time Polyfill Time Ratio
bcadd Small numbers (10 digits) 2.403ms 78.219ms 32.55x
bcsub Small numbers (10 digits) 2.412ms 77.281ms 32.04x
bcmul Small numbers (10 digits) 3.342ms 110.899ms 33.18x
bcdiv Small numbers (10 digits) 2.474ms 112.901ms 45.63x
bcadd Decimals (scale=10) 2.277ms 81.507ms 35.79x
bcsub Decimals (scale=10) 2.547ms 82.089ms 32.23x
bcmul Decimals (scale=10) 3.872ms 115.556ms 29.84x
bcdiv Decimals (scale=10) 6.919ms 118.982ms 17.20x
bcadd Medium numbers (50 digits) 3.575ms 99.634ms 27.87x
bcsub Medium numbers (50 digits) 3.807ms 100.564ms 26.42x
bcmul Medium numbers (50 digits) 18.121ms 135.460ms 7.48x
bcdiv Medium numbers (50 digits) 3.296ms 134.157ms 40.70x
bcpow Power (small exponent) 3.431ms 318.558ms 92.84x
bcpow Power (large base) 5.558ms 273.705ms 49.25x
bcsqrt Square root 53.198ms 42.918ms 0.81x
bcmod Modulo 4.848ms 109.032ms 22.49x
bcadd 100 digits 5.025ms 114.432ms 22.77x
bcmul 100 digits (first 50 digits) 24.546ms 135.825ms 5.53x
bcadd 500 digits 17.748ms 182.892ms 10.30x
bcmul 500 digits (first 50 digits) 24.561ms 125.945ms 5.13x
bcadd 1000 digits 34.129ms 298.261ms 8.74x
bcdiv Scale 20 7.726ms 119.726ms 15.50x
bcsqrt Scale 20 67.639ms 55.180ms 0.82x
bcdiv Scale 50 17.449ms 125.273ms 7.18x
bcsqrt Scale 50 222.107ms 107.697ms 0.48x
bcdiv Scale 100 33.670ms 128.055ms 3.80x
bcsqrt Scale 100 1569.076ms 199.382ms 0.13x

Summary

Summary
========================================
Average performance ratio: 1.67x
Polyfill is on average 1.7x slower than native


🤖 Generated automatically by GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant