refactor: commands/agents/hooks を skills 形式に移行#24
Merged
Conversation
使用頻度分析に基づき、プラグインを全面リファクタリング: - commands(12個)、agents(4個)、hooks を廃止 - skills(6個) を新規作成: commit, commit-push-pr, validate-review, reply-review, github-logs-analyze, plan - 複数リポジトリ対応、PRテンプレート対応を追加 - plugin.json を v2.0.0 に更新 - CLAUDE.md, README.md を skills ベースに書き換え Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 12 minutes and 45 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughこのプルリクエストは、従来のエージェント/コマンド/フック構成を廃し、 Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the eccube-dev-agents plugin by transitioning from an 'Agents' and 'Commands' architecture to a 'Skills' based system, introducing new definitions for git workflows, GitHub reviews, and CI log analysis. Feedback highlights the need to define the {branch} variable in the review validation skill, correctly identify repository roots when using find for git -C commands, and reconsider the strict 'no amend' policy for minor linting fixes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🧹 Nitpick comments (1)
plugins/eccube-dev-agents/skills/github-logs-analyze/SKILL.md (1)
64-82: 出力テンプレートのコードフェンスに言語指定を推奨します。Line 64 のコードブロックは
markdown指定を付けると、表示と lint の一貫性が上がります。🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/eccube-dev-agents/skills/github-logs-analyze/SKILL.md` around lines 64 - 82, The markdown code block that begins just before "## Job 概要" should include a language specifier to improve rendering and linting; change the opening fence from ``` to ```markdown (leave the closing fence as ```), so the block containing "Job 概要" / the example test failures is explicitly marked as markdown.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/eccube-dev-agents/.claude-plugin/plugin.json`:
- Around line 3-4: The plugin metadata is inconsistent: update the
marketplace.json's "version" and "description" fields to match the values in
plugin.json (set "version" to 2.0.0 and replace the old description with "Git
workflow automation, GitHub review management, and CI log analysis toolkit for
development projects") so both manifests use the same metadata; verify the
"version" and "description" keys in marketplace.json are changed to exactly
match the values in plugin.json.
In `@plugins/eccube-dev-agents/skills/reply-review/SKILL.md`:
- Around line 75-83: The fenced code block under the "返信結果" section in SKILL.md
is missing a language tag (MD040); update the opening fence for that block to
include a language specifier (e.g. change the backticks to "```text") so
markdownlint no longer flags it; locate the block containing the "## 返信結果"
content in plugins/eccube-dev-agents/skills/reply-review/SKILL.md and add the
language identifier to the opening ``` fence.
- Around line 31-32: The gh API call `gh api
repos/{owner}/{repo}/pulls/{pr_number}/reviews` only returns the default page
(30 items) and can miss reviews; update the command used in SKILL.md to include
the `--paginate` flag (same approach as the call on Line 30) so all review pages
are retrieved and no replies are overlooked.
In `@plugins/eccube-dev-agents/skills/validate-review/SKILL.md`:
- Around line 52-63: The fenced code block beginning with "## 判定: [妥当 / 非妥当 /
部分的に妥当]" in SKILL.md is missing a language tag (markdownlint MD040); update that
fenced block to include a language identifier (e.g., use ```markdown) so the
linter recognizes it consistently and the block is treated as markdown.
- Around line 36-37: The step that calls gh api
repos/{owner}/{repo}/contents/{path}?ref={branch} uses an undefined {branch};
add a branch-determination step before that call (e.g., obtain branch from the
PR head ref via gh pr view {pr_number} --json headRefName or from an
environment/GitHub context variable, falling back to a default like main) and
then pass that resolved value into ref={branch}; update SKILL.md’s steps around
the gh api call and any references to {branch} so the flow always sets and
documents the source of branch prior to fetching files or running gh pr diff.
In `@README.md`:
- Around line 23-26: Update the "## 必要要件" section in README.md to include Git as
a required dependency: locate the header "## 必要要件" and the existing bullet "-
**GitHub CLI (gh)** - GitHub 統合に必須" and add a new bullet like "- **Git** -
ソース管理と基本操作に必須" (or similar Japanese wording) so the prerequisites clearly list
both Git and gh; ensure ordering and formatting match the surrounding markdown.
---
Nitpick comments:
In `@plugins/eccube-dev-agents/skills/github-logs-analyze/SKILL.md`:
- Around line 64-82: The markdown code block that begins just before "## Job 概要"
should include a language specifier to improve rendering and linting; change the
opening fence from ``` to ```markdown (leave the closing fence as ```), so the
block containing "Job 概要" / the example test failures is explicitly marked as
markdown.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6cd1001b-f2d2-4ce5-a23f-ac1b01d1ce14
📒 Files selected for processing (27)
CLAUDE.mdREADME.mdplugins/eccube-dev-agents/.claude-plugin/plugin.jsonplugins/eccube-dev-agents/agents/bug-investigator.mdplugins/eccube-dev-agents/agents/implementation-analyzer.mdplugins/eccube-dev-agents/agents/log-analyzer.mdplugins/eccube-dev-agents/agents/refactoring-expert.mdplugins/eccube-dev-agents/commands/create-plan.mdplugins/eccube-dev-agents/commands/create-pr.mdplugins/eccube-dev-agents/commands/gemini-search.mdplugins/eccube-dev-agents/commands/gemini.mdplugins/eccube-dev-agents/commands/generate-commit.mdplugins/eccube-dev-agents/commands/github-check.mdplugins/eccube-dev-agents/commands/github-logs-analyze.mdplugins/eccube-dev-agents/commands/load-context.mdplugins/eccube-dev-agents/commands/load-plan.mdplugins/eccube-dev-agents/commands/save-context.mdplugins/eccube-dev-agents/commands/update-plan.mdplugins/eccube-dev-agents/commands/update-pr-description.mdplugins/eccube-dev-agents/hooks/hooks.jsonplugins/eccube-dev-agents/hooks/slack-notify.shplugins/eccube-dev-agents/skills/commit-push-pr/SKILL.mdplugins/eccube-dev-agents/skills/commit/SKILL.mdplugins/eccube-dev-agents/skills/github-logs-analyze/SKILL.mdplugins/eccube-dev-agents/skills/plan/SKILL.mdplugins/eccube-dev-agents/skills/reply-review/SKILL.mdplugins/eccube-dev-agents/skills/validate-review/SKILL.md
💤 Files with no reviewable changes (18)
- plugins/eccube-dev-agents/commands/gemini-search.md
- plugins/eccube-dev-agents/hooks/hooks.json
- plugins/eccube-dev-agents/commands/save-context.md
- plugins/eccube-dev-agents/commands/gemini.md
- plugins/eccube-dev-agents/commands/github-logs-analyze.md
- plugins/eccube-dev-agents/agents/log-analyzer.md
- plugins/eccube-dev-agents/commands/generate-commit.md
- plugins/eccube-dev-agents/agents/refactoring-expert.md
- plugins/eccube-dev-agents/agents/implementation-analyzer.md
- plugins/eccube-dev-agents/commands/update-plan.md
- plugins/eccube-dev-agents/commands/github-check.md
- plugins/eccube-dev-agents/commands/create-plan.md
- plugins/eccube-dev-agents/commands/load-plan.md
- plugins/eccube-dev-agents/agents/bug-investigator.md
- plugins/eccube-dev-agents/commands/load-context.md
- plugins/eccube-dev-agents/commands/create-pr.md
- plugins/eccube-dev-agents/hooks/slack-notify.sh
- plugins/eccube-dev-agents/commands/update-pr-description.md
- find .git の結果から親ディレクトリ(リポジトリルート)を特定する記述に修正
- validate-review の {branch} を {commit_id} に変更し取得フローを明示
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
未確認のレビューコメントに対して自動返信してしまう問題を修正。 同一会話内で validate-review を実行済みのコメントのみを返信対象とする。 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
新規 Skills
commitcommit-push-prvalidate-reviewreply-reviewgithub-logs-analyzeplan廃止
commands/: 12ファイル (gemini-search, github-check, save-context, load-context, create-plan 等)agents/: 4ファイル (bug-investigator, implementation-analyzer, log-analyzer, refactoring-expert)hooks/: Slack通知 (hooks.json, slack-notify.sh)更新
plugin.json: v2.0.0、description/keywords 更新CLAUDE.md,README.md: skills ベースに全面書き換えTest plan
ls plugins/eccube-dev-agents/skills/*/SKILL.mdで6つの Skill が存在すること/helpで表示されること/commit,/commit-push-pr等の Skill が正しく動作することSummary by CodeRabbit
新機能
改善
更新
削除