Skip to content

Add support for other function parameters #12

Description

@nandanmen

The transformer currently only supports Identifier-based function parameters, e.g.

function hello(a, b)

It doesn't support parameters made using things like array destructuring, object destructuring, rest operators, assignment patterns, etc. All of the following examples will throw errors:

  1. Array destructuring
function ([a, b])
  1. Object destructuring
function ({ a, b })
  1. Rest operators
function (a, b, ...others)
  1. Assignment/default parameters
function (a, b = 0)
function (a, b, c = a * b)

It would be nice to add support for these, however it's important to note that this will impact both the transformer and the application since:

  • for the transformer, we have to be able to parse and correctly record these parameters, and
  • for the app, we would have to change the argument form to correctly send the appropriate arguments to the function.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    appfeaturecore feature unrelated to uxtransformertickets related to the custom babel transform

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions