Skip to content

Update nuspec to place library under nano TFM#23

Merged
josesimoes merged 2 commits intodevelopfrom
copilot/update-nuspec-library-location
Mar 4, 2026
Merged

Update nuspec to place library under nano TFM#23
josesimoes merged 2 commits intodevelopfrom
copilot/update-nuspec-library-location

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 4, 2026

The nuspec was placing library files directly under lib\ and declaring dependencies without a target framework group, neither of which aligns with the .NETnanoFramework1.0 TFM convention used across nanoFramework packages.

Changes

  • Dependency group: Wrapped nanoFramework.CoreLibrary dependency in <group targetFramework=".NETnanoFramework1.0">
  • File target: Replaced five individual file entries (.dll, .pdb, .pdbx, .pe, .xml) with a single wildcard targeting lib\netnano1.0
<!-- Before -->
<dependencies>
  <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.35" />
</dependencies>
...
<file src="...\System.Device.I2c.Slave.dll" target="lib\System.Device.I2c.Slave.dll" />
<file src="...\System.Device.I2c.Slave.pdb" target="lib\System.Device.I2c.Slave.pdb" />
<!-- ...etc -->

<!-- After -->
<dependencies>
  <group targetFramework=".NETnanoFramework1.0">
    <dependency id="nanoFramework.CoreLibrary" version="2.0.0-preview.35" />
  </group>
</dependencies>
...
<file src="System.Device.I2c.Slave\bin\Release\System.Device.I2c.Slave.*" target="lib\netnano1.0" />

Follows the pattern established in nanoframework/System.Device.Adc@aab7bca.

Original prompt

This section details on the original issue you should resolve

<issue_title>Update nuspec to place library under nano TFM</issue_title>
<issue_description>### Details about task
Most of the nuspec files are not using the correct location to place the files.
Files (DLL, PE, PDBX and XML for IntelliSense) should be placed under "lib\netnano1.0" (currently are being placed under "lib" only.
Also they should declare a dependency group for ".NETnanoFramework1.0" target framework.
At the same time those still naming the various file types should use a wildcard instead (e.g. "...\Release\mscorlib.*).
The correct pattern should be (take this nuspec as sample):
nanoframework/System.Device.Adc@aab7bca

Do not change anything else on the nuspec file.

Description

</issue_description>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: josesimoes <1881520+josesimoes@users.noreply.github.com>
@josesimoes josesimoes marked this pull request as ready for review March 4, 2026 19:16
Copilot AI changed the title [WIP] Update nuspec to place library under nano TFM Update nuspec to place library under nano TFM Mar 4, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 4, 2026

@josesimoes josesimoes merged commit 96ed463 into develop Mar 4, 2026
8 checks passed
@josesimoes josesimoes deleted the copilot/update-nuspec-library-location branch March 4, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants