Correctly incorporate correlated noise in WidebandDownhillFitter + Plot whitened DM residuals in pintk#1968
Open
abhisrkckl wants to merge 14 commits intonanograv:masterfrom
Open
Correctly incorporate correlated noise in WidebandDownhillFitter + Plot whitened DM residuals in pintk#1968abhisrkckl wants to merge 14 commits intonanograv:masterfrom
WidebandDownhillFitter + Plot whitened DM residuals in pintk#1968abhisrkckl wants to merge 14 commits intonanograv:masterfrom
Conversation
WidebandDownhillFitterWidebandDownhillFitter + Plot whitened DM residuals in pintk
WidebandDownhillFitter + Plot whitened DM residuals in pintkWidebandDownhillFitter + Plot whitened DM residuals in pintk
Contributor
Author
Contributor
|
Hi, @abhisrkckl . I don't know the correlated-noise code well enough to really review this. Maybe @rossjjennings or @demorest or somebody else can look more closely? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
+ Coverage 70.57% 70.60% +0.03%
==========================================
Files 110 110
Lines 25775 25730 -45
Branches 4060 4059 -1
==========================================
- Hits 18190 18167 -23
+ Misses 6443 6415 -28
- Partials 1142 1148 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR implements the correct handling of DMGP in
WidebandDownhillFitterbased on https://arxiv.org/abs/2505.05274The major changes are as follows.
WidebandDownhillFitternow uses the wideband design matrix computed byTimingModel.wideband_designmatrixinstead of constructing it inside the fitter.WidebandDownhillFitternow uses the wideband Ndiag computed byTimingModel.scaled_wideband_uncertaintyinstead of constructing it inside the fitter.WidebandDownhillFitternow computes the wideband residuals usingWidebandTOAResiduals.calc_wideband_residsinstead of doing it inside the fitter.WidebandDownhillFitterandWidebandStatenow have a structure more like other downhill fitter and state classes.The GLS fitting expression is

where y, N, and M are the wideband residuals (2ntoa), wideband Ndiag (2ntoa x 2ntoa), and the wideband design matrix (2ntoa x nparam). Phi is the same as in narrowband timing (it contains the prior variances).
Also implements a new option to plot whitened DM residuals in pintk.