Removing astropy.constants.G from various calculations#1975
Merged
abhisrkckl merged 3 commits intonanograv:masterfrom Apr 3, 2026
Merged
Removing astropy.constants.G from various calculations#1975abhisrkckl merged 3 commits intonanograv:masterfrom
astropy.constants.G from various calculations#1975abhisrkckl merged 3 commits intonanograv:masterfrom
Conversation
Contributor
Author
|
Note that there is still extensive use of |
Contributor
Author
Now this has been fixed too. |
Contributor
Author
|
As a related note, our value of G*Msun: has a newer value: from the website cited above. Fractional difference is ~1e-10. But we generally don't claim absolute precision at this level (for things like masses) so I'm not sure it's worth changing. |
abhisrkckl
reviewed
Mar 28, 2026
Contributor
|
I will merge this if ready. |
Contributor
Author
|
I think it's ready if you don't have further issues (I agree some of it is not optimal, but not sure what else to do) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To improve consistency, removing
astropy.constants.Gfrom various derived quantities in favor ofpint.GMsunorpint.Tsun. The differences are small, ~1e-10. And issues are still possible (e.g., if a mass is input in kg instead of Msun, it will still need to be converted). But this is better (I think).