Conversation
|
So the tests that fail are in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
==========================================
- Coverage 70.58% 70.25% -0.34%
==========================================
Files 110 109 -1
Lines 25736 25556 -180
Branches 4054 4058 +4
==========================================
- Hits 18167 17954 -213
- Misses 6428 6459 +31
- Partials 1141 1143 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@scottransom or @paulray : is this actually needed? |
|
I don't think it is needed. I just looked at the history and I think it was intended as being the core of a pure new orbit model that Anne Archibald was writing. But that obviously never happened. It is probably fine to get rid of it, although it seems like nice code! |
I have no particular animus, but it can be a little confusing. Could just add some "DEPRECATED" notes to the files instead. |
|
Yes, I think this is OK to remove. The code will be available in the git history if needed in the future. |
|
OK, in that case I think you can merge this. |
#1974 : I don't know if this module is used. I suspect not. So delete to remove confusion.