[WIP] Don't need to calculate cdf with np.where to plot p-p plot#26
Open
vhaasteren wants to merge 1 commit intonanograv:devfrom
Open
[WIP] Don't need to calculate cdf with np.where to plot p-p plot#26vhaasteren wants to merge 1 commit intonanograv:devfrom
vhaasteren wants to merge 1 commit intonanograv:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't merge this yet, I first want to have the discussion.
I've been wondering about the following. When making a p-p plot, la forge and some other packages I've seen calculate the cdf by counting realizations with up to a certain p-value. But the p-value is supposed to be distributed according to Uniform(0, 1). That means you can just straight up plot p-value vs q. Compared to the 'counting' way, this means you have slightly more independent datapoins in the p-p plot.
See what I mean at the code diff below. The difference is very minimal, but it's more elegant.
Is there a reason not to be changing this?