chore(schemas): re-vendor the CRD schemas after the datastore contract fix - #61
Merged
Conversation
…t fix
Picks up eks-agent-platform@96bb2f5, which corrected the datastore contract this
repo's Platform CR is authored against.
What changed in the schema:
* `status.datastores[].drift` is gone. It was written by nothing and its
description read "Empty when in sync", so a permanently empty list read as a
positive assertion that the datastore matched its declaration.
* The per-field `Drift: converged` / `Drift: reported` descriptions are gone
across every datastore kind. The operator holds no AWS client for RDS,
DynamoDB, ElastiCache, SQS or MSK and no drift machinery at all; drift is
detected by landing-zone's scheduled `tofu plan` and never reaches the CR.
* `minACU` accepts "0" — Aurora Serverless v2 auto-pause — and both ACU fields
are now capped at Aurora's real 256 maximum instead of admitting up to 999.
Two CEL rules carry what a pattern cannot: maxACU >= minACU, and auto-pause
requiring Aurora PostgreSQL 16 or later.
* `spec.datastores` gains maxItems and the ACU strings gain maxLength, without
which the apiserver's CEL cost estimator rejects the CRD outright.
* The datastore status `phase` no longer advertises `Drifted`, which had no
constant in the operator and was unreachable — the datastore phase is the
owning Platform's phase, copied.
The committed platform.yaml validates unchanged against the tightened schema.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up eks-agent-platform@96bb2f5, which corrected the datastore contract this repo's Platform CR is authored against.
What changed in the schema
status.datastores[].driftis gone. It was written by nothing, and its description read "Empty when in sync" — so a permanently empty list read as a positive assertion that the datastore matched its declaration.Drift: converged/Drift: reporteddescriptions are gone across every datastore kind. The operator holds no AWS client for RDS, DynamoDB, ElastiCache, SQS or MSK, and no drift machinery at all. Drift is detected by landing-zone's scheduledtofu planand never reaches the CR.minACUaccepts"0"— Aurora Serverless v2 auto-pause — and both ACU fields are capped at Aurora's real 256 maximum instead of admitting up to 999. Two CEL rules carry what a pattern cannot:maxACU >= minACU, and auto-pause requiring Aurora PostgreSQL 16+.spec.datastoresgainsmaxItemsand the ACU strings gainmaxLength, without which the apiserver's CEL cost estimator rejects the whole CRD.phaseno longer advertisesDrifted, which had no constant in the operator and was unreachable — the datastore phase is the owning Platform's phase, copied.Verification
npm run platform:validatepasses: the committedplatform.yamlvalidates unchanged against the tightened schema, and the gate's own self-test still rejects every seeded defect.