Skip to content

chore: renovate opens PRs instead of committing to main - #63

Merged
stxkxs merged 2 commits into
mainfrom
chore/renovate-disarm-automerge
Aug 8, 2026
Merged

chore: renovate opens PRs instead of committing to main#63
stxkxs merged 2 commits into
mainfrom
chore/renovate-disarm-automerge

Conversation

@stxkxs

@stxkxs stxkxs commented Aug 8, 2026

Copy link
Copy Markdown
Member

Why now

This config has never executed. No Renovate app is installed on the org, so every rule in here is a statement of intent that nothing has ever acted on — including the automerge rules. That is what makes turning Renovate on a live risk rather than a routine switch, and it is why this lands before the app does.

Five repos carry a renovate.json with automerge enabled: this one, the three sibling tenant repos, and eks-agent-platform (#204).

What was armed

The patch+minor rule set automerge: true with automergeType: "branch".

Branch mode does not open a pull request at all. Renovate pushes the update to a branch, waits for CI, and commits it to the base branch directly. On the first run that would land a batch of dependency updates on main, unreviewed — and it contradicts how this org works, where changes reach main through a pull request.

What changed

before after
patch+minor rule automerge: true automerge: false
automergeType: "branch" automergeType: "pr"

The type is corrected rather than deleted, so re-enabling automerge later cannot silently reintroduce direct-to-main commits. Whoever flips the boolean gets PR-based merging.

The rest of the posture was already right and is untouched: majors need review, and CVE-triggered updates are excluded from automerge twice over — once in vulnerabilityAlerts and once as the last packageRule, since per-package rules override top-level settings.

Verified

renovate-config-validator after the change: config valid, no migration needed.

Next step, which is yours

Installing the Renovate GitHub App is the remaining half. The acceptance test that actually closes the loop is the Dependency Dashboard issue appearing in each repo — not the config validating, which is what it has always done while doing nothing.

https://claude.ai/code/session_012iMnbboJuiUMSvu7n8oRhz

stxkxs added 2 commits August 7, 2026 17:04
This config has never executed. No Renovate app is installed on the org, so
every rule in here is a statement of intent that nothing has ever acted on —
including the automerge rules, which is what makes turning it on a live risk
rather than a routine switch.

The patch+minor rule set automerge true with automergeType "branch". Branch mode
does not open a pull request at all: Renovate pushes the update to a branch,
waits for CI, and commits it to the base branch directly. On the first run that
would land a batch of dependency updates on main unreviewed, and it contradicts
how this org works — changes reach main through a pull request.

automerge is now false and automergeType is "pr". The type is corrected rather
than deleted so that re-enabling automerge later cannot silently reintroduce
direct-to-main commits; whoever flips the boolean gets PR-based merging.

The rest of the posture was already right and is unchanged: majors need review,
and CVE-triggered updates are excluded from automerge twice over — once in
vulnerabilityAlerts and once as the last packageRule, since per-package rules
override top-level settings.

Validated with renovate-config-validator: no migration needed, no errors.
The config rewrite expanded single-element arrays across multiple lines, which
biome collapses back inline. Formatting only; no rule, schedule or automerge
value changes.
@stxkxs
stxkxs merged commit a35bb8d into main Aug 8, 2026
14 checks passed
@stxkxs
stxkxs deleted the chore/renovate-disarm-automerge branch August 8, 2026 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant