docs: pin the operator chart whose README is not wrong - #196
Merged
Conversation
0.6.5 is a documentation-only release. Its rendered manifests are identical to 0.6.4's — 34 changed lines against this repo's production values, all of them the helm.sh/chart label. The pin moves anyway, because the pinned version is also the pointer to the chart's documentation. 0.6.4's README carries an `### operator SLO (slo.*)` section describing values the chart removed at 0.6.0 and that its own values.schema.json now rejects, so following it produces `additional properties 'slo' not allowed` rather than the alerting it promises. An OCI tag here is immutable by policy — the release job refuses to overwrite a published version — so those bytes are permanent, and anyone who inspects the chart this fleet resolves reads them. Correcting the README in source and leaving the fleet pinned a version behind it would have left the defect exactly where it does harm: in the artifact a reader actually reaches.
CI Results
All checks passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.6.5 is a documentation-only release. Its rendered manifests are identical to 0.6.4's — 34 changed lines against this repo's production values, all of them the
helm.sh/chartlabel:So why move the pin
Because the pinned version is also the pointer to the chart's documentation.
0.6.4's README carries an
### operator SLO (slo.*)section describing values the chart removed at 0.6.0 and that its ownvalues.schema.jsonnow rejects. Following it produces:An OCI tag here is immutable by policy — the release job refuses to overwrite a published version — so those bytes are permanent. Confirmed against the registry just now:
Correcting the README in source (eks-agent-platform#213) and leaving the fleet pinned a version behind it would leave the defect exactly where it does harm — in the artifact a reader actually reaches.
task validate: 109 addon×env combinations, 0 failed.