Target the ExternalSecret API version the cluster serves - #79
Merged
Conversation
The external-secrets release the eks-gitops addon installs still lists v1beta1 on the CRD but no longer serves it: v1 served=true v1beta1 served=false A declared-but-unserved version is the confusing shape. The CRD names it, so the manifest looks like it targets something real, and nothing local disagrees — helm renders it and schema validation accepts it. Only the API server knows, and it answers at install time with `no matches for kind "ExternalSecret" in version "external-secrets.io/v1beta1"`, so this chart could not install at all. Every field used here — refreshInterval, secretStoreRef, target and the data remoteRefs — is present in v1 unchanged, and the ClusterSecretStore it references was always v1. A version bump and nothing more. Found by sweeping the org for the declaration after it broke a live install of portal. This is the last of the three tenant repos that carried it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external-secrets release the eks-gitops addon installs still lists
v1beta1on the CRD but no longer serves it:Declared-but-unserved is the confusing shape: the CRD names the version, so the manifest looks like it targets something real, and nothing local disagrees — helm renders it, schema validation accepts it, chart lint is happy. Only the API server knows, and it answers at install time with
no matches for kind "ExternalSecret" in version "external-secrets.io/v1beta1".So this chart could not install at all.
Every field used here —
refreshInterval,secretStoreRef,targetand thedataremoteRefs — exists inv1unchanged, and theClusterSecretStoreit references was alwaysv1. A version bump and nothing more.Found by sweeping the org after this broke a live install of
portal(nanohype/portal#161). This is the last of the tenant repos that carried it — closes this repo's share of nanohype/eks-gitops#203.